-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libaec] Fix usage call error #43917
base: master
Are you sure you want to change the base?
Conversation
I think we need a better understanding of the original problem before we start trying to change where this port is installing things. In particular, if someone has made a separate 'szip' port, trying to hide a conflict with it by moving headers and libs elsewhere here doesn't actually fix the problem, as they'll still be left with conflicts at link time. The right change might be to add a port 'szip' and change libaec to point to it, but I think the customer needs to explain how they got in that situation better. |
OK, I will continue to follow up with the customer to understand the real scenario that caused this issue. |
The original problem is having the now-delisted This PR isn't helpful IMO. There could be extra checks and message, but they would not cover all installation orders anyways. There could be an empty szip depending on the new alternative. |
Removed header file conflict fix. Only fix usage errors. |
Please provide a minimum reprocible example of the problem you are trying to fix. Once the problem is confirmed, and it is a port problem, we can talk about a fix in the port. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The szip compatible interface is an optional add-on.
You need to test both interfaces independently because they are used independently.
find_package(libaec CONFIG REQUIRED) | ||
|
||
add_executable(compression main.c) | ||
target_link_libraries(compression PRIVATE sz aec sz_shared aec_shared) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is obvious that this doesn't make sense.
(Yes, this is what the uninformed heuristics prints. I expect you to see the problems.)
find_package(libaec CONFIG REQUIRED) | ||
|
||
add_executable(compression main.c) | ||
target_link_libraries(compression PRIVATE sz aec sz_shared aec_shared) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, maybe don't try to fix a port until you found out how it is meant to be used.
AFAICT proper use generally lists exactly one target (expression) after PRIVATE
.
This is probably the most important file in the test.
Fix the following error.
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.Usage test passed with x64-windows triplet.