Fix my comments in #40 #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et str: Box<str> = Box::from("")`
Or `let str = Box::<str>::from("")`
There is place to expand more on the possibilities with it (e.g `{0}` or `{name}, name = `, but it can be seen in the documentation.
atifaziz
reviewed
Feb 13, 2024
There was a problem hiding this comment.
@ChayimFriedman2 Thanks a ton for submitting and apologies for getting back to you just now. I can't promise when I'll get the time to go over your changes, but I wanted to drop a short note to say that it's noted and on my queue. Appreciate some more patience on your end.
I also included struct update syntax, because I believe it is parallel to
withexpressions, but I can remove it if requested.
This is something being addressed by PR #37.
Best reviewed commit-by-commit.
Awesome and thank you for doing this! It always helps!
The example is a bit complicated, but I haven't found a better one.
ChayimFriedman2
force-pushed
the
my_comments
branch
from
ed365af to
fa0ade5
Compare
|
Removed struct update syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40.
I also included struct update syntax, because I believe it is parallel to
withexpressions, but I can remove it if requested.Best reviewed commit-by-commit.