Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merge issue with release bump down for python3 libs in toolchain manifests #12275

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

sameluch
Copy link
Contributor

@sameluch sameluch commented Feb 10, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Following this merge, the release number for python3-libs went from 6 to 5 unintentionally. PR to fix the issue

Change Log
  • update toolchain manifest files for fasttrack to have correct version of python3-libs
Does this affect the toolchain?

YES

Test Methodology
  • PR checks

Copy link
Member

@anphel31 anphel31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I see that the 3.0 branch version of python is still on release 5 https://github.com/microsoft/azurelinux/blob/3.0/SPECS/python3/python3.spec#L9

@jslobodzian jslobodzian merged commit 55aa3f6 into fasttrack/3.0 Feb 10, 2025
23 checks passed
@jslobodzian jslobodzian deleted the sammeluch/python3-libs-manifest-fix branch February 10, 2025 23:40
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

  • 3.0-dev ✅ -> Skipped

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=732853&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants