Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid dracut collision between [mktemp] and [find -not -path '*.ko*'] #12218

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

bfjelds
Copy link
Member

@bfjelds bfjelds commented Feb 4, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

dracut.sh uses mktemp to create temporary workspace. The pattern provided is dracut.XXXXXX. Rarely, the temporary folder is dracut.ko*. This conflicts with a find filter used in dracut.sh: -not -path '*.ko*'. When the conflict occurs, dracut fails to install many required modules (including systemd-core), resulting in an initramfs that cannot be booted.

The patch prevents this conflict by prepending d to the mktemp substitution.

The matching upstream PR: dracut-ng/dracut-ng#1198

Change Log
  • add patch to modify dracut.sh
Does this affect the toolchain?

NO

Test Methodology

@bfjelds bfjelds requested a review from a team as a code owner February 4, 2025 21:58
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant