Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jquery dependency #295

Merged
merged 1 commit into from
Mar 6, 2019
Merged

remove jquery dependency #295

merged 1 commit into from
Mar 6, 2019

Conversation

devaradhanm
Copy link
Contributor

@devaradhanm devaradhanm commented Mar 5, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000 - n/a
  • Added relevant unit test for your changes. (npm run test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage - n/a
  • Ran precheckin (npm run precheckin)
  • Added screenshots/GIFs for UI changes. - n/a

Description of changes

removing jquery since we are not using it anymore. Found this issue to identify why we need unsafe-eval in our manifest. we still can't remove unsafe-eval due to this issue - dequelabs/axe-core#1175

Notes for reviewers

Validated fast pass, adhoc tools, assessment, insights page to trigger core background operations to see if this causes any failure

@devaradhanm devaradhanm requested a review from a team March 5, 2019 22:53
@markreay markreay self-assigned this Mar 5, 2019
@peterdur peterdur merged commit ea06b86 into master Mar 6, 2019
@peterdur peterdur deleted the users/devaradhanm/security branch March 6, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants