Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example app to use broadcast-signal in tinylicious #17543

Merged
merged 37 commits into from
Oct 30, 2023
Merged

Update example app to use broadcast-signal in tinylicious #17543

merged 37 commits into from
Oct 30, 2023

Conversation

ghoshkaj
Copy link
Contributor

@ghoshkaj ghoshkaj commented Sep 28, 2023 •
edited
Loading

AB#4722

The purpose of this PR is to mainline the dev broadcast-signal branch.

This PR consumes the changes in the server code and showcase how to broadcast-signal mechnaism in the example external-data app. This PR is blocked on both the #16451 as well as the #16452.

Closing an older version of this PR in favour of this one.

@github-actions github-actions bot added area: examples Changes that focus on our examples area: server Server related issues (routerlicious) dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Sep 28, 2023
@ghoshkaj
uncommit messed up pnpm-lock
7546ea7
@ghoshkaj
change url for broadcast-signal to be
bc4ffaa
@ghoshkaj
Merge remote-tracking branch 'upstream/main' into update-example-app-…
eb4ed7b 
…to-use-broadcast-signal
@ghoshkaj
Merge remote-tracking branch 'upstream/main' into update-example-app-…
8c48dc4 
…to-use-broadcast-signal
@ghoshkaj
update to tinylicious 2.0.2
30dbec2
@ghoshkaj
Merge remote-tracking branch 'upstream/main' into update-example-app-…
428532e 
…to-use-broadcast-signal
@ghoshkaj
separate out tenantId and documentId
5d563e7
@ghoshkaj
Merge branch 'microsoft:main' into update-example-app-to-use-broadcas…
1b65ba4 
…t-signal
@ghoshkaj
receive the signal from tinylicious
176c0eb
@ghoshkaj
install [email protected] for workspace
c51d522
@ghoshkaj
Revert "install [email protected] for workspace"
98e5bf4 
This reverts commit c51d522.
@ghoshkaj
Merge remote-tracking branch 'upstream/main' into update-example-app-…
08d3c24 
…to-use-broadcast-signal
@ghoshkaj
uses 2.0.2 fo all other tinylicious imports as well
a4e781d
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc labels Oct 16, 2023
@ghoshkaj ghoshkaj marked this pull request as ready for review October 17, 2023 18:48
@ghoshkaj ghoshkaj requested review from msfluid-bot and a team as code owners October 17, 2023 18:48
@ghoshkaj ghoshkaj requested a review from a team as a code owner October 17, 2023 18:48
@ghoshkaj ghoshkaj requested a review from a team October 17, 2023 18:48
alexvy86
alexvy86 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

server/routerlicious/packages/lambdas/src/alfred/index.ts Outdated Show resolved Hide resolved
examples/external-data/src/mock-customer-service/service.ts Outdated Show resolved Hide resolved
examples/external-data/src/mock-customer-service/service.ts Outdated Show resolved Hide resolved
examples/external-data/src/mock-customer-service/service.ts Show resolved Hide resolved
examples/external-data/src/mock-customer-service/service.ts Outdated Show resolved Hide resolved
examples/external-data/src/utilities/clientManager.ts Outdated Show resolved Hide resolved
examples/external-data/src/mock-customer-service/service.ts Show resolved Hide resolved
examples/external-data/tests/customerService.test.ts Outdated Show resolved Hide resolved
examples/external-data/tests/customerService.test.ts Outdated Show resolved Hide resolved
examples/external-data/tests/customerService.test.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the area: server Server related issues (routerlicious) label Oct 18, 2023
@ghoshkaj ghoshkaj requested a review from alexvy86 October 19, 2023 00:04
@ghoshkaj ghoshkaj requested review from alexvy86 and a team October 30, 2023 13:41
alexvy86
alexvy86 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launch

@ghoshkaj ghoshkaj merged commit 8cee81b into microsoft:main Oct 30, 2023
@ghoshkaj ghoshkaj deleted the update-example-app-to-use-broadcast-signal branch October 30, 2023 17:00
@ghoshkaj ghoshkaj mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvy86 alexvy86 alexvy86 approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghoshkaj @alexvy86