Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format python now that auto-formatting is actually enabled #589

Merged
merged 5 commits into from
Dec 28, 2023
Merged

Conversation

Lohrer
Copy link
Collaborator

@Lohrer Lohrer commented Dec 27, 2023

What does this change intend to accomplish?

See title.

Checklist

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

Attention: 144 lines in your changes are missing coverage. Please review.

Comparison is base (132a762) 51.60% compared to head (61e5599) 51.59%.

Files Patch % Lines
amplipi/rt.py 24.00% 38 Missing ⚠️
amplipi/streams.py 30.23% 30 Missing ⚠️
amplipi/display/epd2in13_V3.py 0.00% 27 Missing ⚠️
amplipi/app.py 62.96% 10 Missing ⚠️
amplipi/ctrl.py 85.36% 6 Missing ⚠️
amplipi/display/einkdisplay.py 0.00% 6 Missing ⚠️
amplipi/hw.py 84.37% 5 Missing ⚠️
amplipi/updater/asgi.py 0.00% 5 Missing ⚠️
amplipi/eeprom.py 33.33% 4 Missing ⚠️
amplipi/extras.py 0.00% 4 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   51.60%   51.59%   -0.01%     
==========================================
  Files          24       24              
  Lines        5676     5675       -1     
==========================================
- Hits         2929     2928       -1     
  Misses       2747     2747              
Flag Coverage Δ
unittests 51.59% <48.93%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lohrer Lohrer requested a review from linknum23 December 27, 2023 20:52
@Lohrer Lohrer marked this pull request as ready for review December 27, 2023 20:52
Copy link
Contributor

@linknum23 linknum23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to check with @rtertiaer to verify that auto-formatting works for his vi-based development workflow.

@linknum23
Copy link
Contributor

Note: I had to update my python version to get this to work. Using python 3.7, the same version on amplipi has failures with the jedi server.

@linknum23 linknum23 self-requested a review December 28, 2023 18:12
@Lohrer Lohrer merged commit 71142b4 into main Dec 28, 2023
3 checks passed
@Lohrer Lohrer deleted the format_py branch January 3, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants