Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template #577

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Pull request template #577

merged 1 commit into from
Dec 21, 2023

Conversation

rtertiaer
Copy link
Contributor

I'd like to implement a pull request template to set expectations and bowling bumpers around feature/bug development. This will particularly help us accept quality contributions from new contributors.

Did I miss anything? Does this feel extra? I borrowed most of this from here, which has a host of other pull request templates to peruse.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f5d89a) 51.60% compared to head (c3446d6) 51.60%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   51.60%   51.60%           
=======================================
  Files          24       24           
  Lines        5676     5676           
=======================================
  Hits         2929     2929           
  Misses       2747     2747           
Flag Coverage Δ
unittests 51.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtertiaer rtertiaer force-pushed the pull_request_template branch from 335fd28 to cbd7790 Compare December 21, 2023 20:29
@rtertiaer rtertiaer force-pushed the pull_request_template branch from cbd7790 to c3446d6 Compare December 21, 2023 20:30
Copy link
Collaborator

@Lohrer Lohrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good initial version of this. After getting a few miles PRs on this we should double-check it turned out to make sense and there isn't anything else to add.

@rtertiaer rtertiaer merged commit 43174da into main Dec 21, 2023
3 checks passed
@rtertiaer rtertiaer deleted the pull_request_template branch December 21, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants