Webapp2 lock volume #510
Closed
Webapp2 lock volume #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… they're read and written on the front and calculated on the back yet
|
Abandoning this branch temporarily to work on higher priority things, but this will be a good feature to have once I get back to it |
|
This branch is likely stale and will need to be rebased/restarted whenever I get back to it |
|
@SteveMicroNova if you intend to work on this, can you re-target this PR to |
|
My instincts are to close this until we decide how to implement this. Lets wait for more feedback on the new UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a lock to the volume sliders on the frontend (and logic to support it to the backend) that will allow volume to be locked so that it can't be changed, generally useful when a zone is part of a group but doesn't want to be effected by the same volume changes as the group as a whole