Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value for onApply on Streams Modal #1029

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Set default value for onApply on Streams Modal #1029

merged 1 commit into from
Feb 20, 2025

Conversation

SteveMicroNova
Copy link
Contributor

What does this change intend to accomplish?

In #1015, I broke stream swapping and did not notice as I was only trying to touch stream creating. This PR makes it so that the modal closes again by not throwing errors due to the lack of onApply in most instances of that modal flow.

Checklist

  • Have you tested your changes and ensured they work?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

@SteveMicroNova SteveMicroNova merged commit 42e8c6e into main Feb 20, 2025
3 checks passed
@SteveMicroNova SteveMicroNova deleted the StreamsModalOnApply branch February 20, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linknum23 linknum23 linknum23 approved these changes

@klay2000 klay2000 Awaiting requested review from klay2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveMicroNova @linknum23