Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support conforming singer property names to target identifier constraints in SQL sinks #1039

Merged
merged 38 commits into from
Oct 20, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
c0917b0
start on schema and table creation on
Oct 4, 2022
1af0a57
linting
Oct 4, 2022
5e41500
add default schema name
Oct 4, 2022
05ea897
add schema to table metadata
Oct 4, 2022
7bb0e70
Merge branch 'main' into kgpayne/issue1027
Oct 4, 2022
6281e7d
Merge branch 'main' into kgpayne/issue1027
Oct 4, 2022
19b3ccb
Merge branch 'main' into kgpayne/issue1027
Oct 4, 2022
f22fe86
started on conforming columns in SQL streams
Oct 5, 2022
6d7e156
Merge branch 'main' into kgpayne/issue1027
Oct 5, 2022
059301e
Merge branch 'main' into kgpayne/issue1027
edgarrmondragon Oct 5, 2022
e68c045
Add missing import for `singer_sdk.helpers._catalog`
edgarrmondragon Oct 5, 2022
614c4de
Update singer_sdk/sinks/sql.py
Oct 7, 2022
e91ccfd
Update singer_sdk/sinks/sql.py
Oct 7, 2022
68b44a6
Update singer_sdk/sinks/sql.py
Oct 7, 2022
37ec7a6
Update singer_sdk/sinks/sql.py
Oct 7, 2022
0347950
Merge branch 'main' into kgpayne/issue1027
Oct 11, 2022
4db0745
Merge branch 'kgpayne/issue1027' into kgpayne/issue1021
Oct 11, 2022
c7abd72
undo connection module
Oct 11, 2022
c59bd5e
fix copy-paste formatting
Oct 11, 2022
7fd3bb1
fix test
Oct 11, 2022
615e5a6
more connector changes
Oct 11, 2022
4171a95
fix docstring
Oct 11, 2022
5bf574a
Merge branch 'main' into kgpayne/issue1027
Oct 11, 2022
b60ddca
add schema creation test
Oct 12, 2022
1e28606
Merge branch 'kgpayne/issue1027' of github.com:meltano/sdk into kgpay…
Oct 12, 2022
b49ee49
Merge branch 'main' into kgpayne/issue1027
Oct 12, 2022
f244c29
Merge branch 'kgpayne/issue1027' into kgpayne/issue1021
Oct 12, 2022
6cfdfb9
minor fix
Oct 12, 2022
7b2437a
add duplicate conformed key check
Oct 12, 2022
04dd540
Update samples/sample_tap_hostile/hostile_streams.py
Oct 12, 2022
10565a7
add raise on conformed name clash, and leading number conformer
Oct 12, 2022
e65cace
mypy and linting
Oct 12, 2022
d1a12dc
pr suggestion
Oct 12, 2022
3e92f07
Merge branch 'main' into kgpayne/issue1027
Oct 13, 2022
03538d4
Merge branch 'kgpayne/issue1027' into kgpayne/issue1021
Oct 13, 2022
0d7c431
more linting and mypy
Oct 13, 2022
3f9aa9e
Merge branch 'main' into kgpayne/issue1021
Oct 20, 2022
fd1a7a6
fix merge duplicates
Oct 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix copy-paste formatting
  • Loading branch information
Ken Payne committed Oct 11, 2022
commit c59bd5e8fd3d30510d69fa4cba55d5ed772e234c
2 changes: 1 addition & 1 deletion singer_sdk/sinks/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

from singer_sdk.plugin_base import PluginBase
from singer_sdk.sinks.batch import BatchSink
from singer_sdk.sql import SQLConnector
from singer_sdk.streams import SQLConnector


class SQLSink(BatchSink):
Expand Down
Loading