Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Bumps and auto discovering packages for schema creation #2

Closed
wants to merge 4 commits into from
Closed

Conversation

TreyBastian
Copy link

Nothing much to say on this that hasn't been said in the commit messages.

The schema creation no longer requires the ExposedTables annotation and versions have been bumped

* added exclude-packages property to exclude packages from the auto-generated DDL

* deprecated @ExposedTables

* cleaned up some formatting
* added tests to test new DDL feature
* updated the schema creation instructions
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #2 into master will increase coverage by 3.89%.
The diff coverage is 92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #2      +/-   ##
============================================
+ Coverage     80.95%   84.84%   +3.89%     
  Complexity        5        5              
============================================
  Files             4        4              
  Lines            21       33      +12     
============================================
+ Hits             17       28      +11     
- Misses            4        5       +1
Impacted Files Coverage Δ Complexity Δ
.../github/mduesterhoeft/exposed/ExposedProperties.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ithub/mduesterhoeft/exposed/DatabaseInitializer.kt 88.46% <100%> (+2.74%) 0 <0> (ø) ⬇️
...posed/SpringTransactionExposedAutoConfiguration.kt 100% <100%> (ø) 3 <2> (ø) ⬇️
.../mduesterhoeft/exposed/ExposedAutoConfiguration.kt 66.66% <50%> (ø) 2 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e5364...1e74d7e. Read the comment docs.

@TreyBastian
Copy link
Author

It's been 2 weeks since i've submited this and I've seen no movement. Is this no longer maintained? I'll gladly take this over.

@TreyBastian
Copy link
Author

Update -- I've submited a PR to exposed to add spring boot starter functionality that should be merged soon. JetBrains/Exposed#582

Much easier to maintain versioning when it's at the source closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant