Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(newsletter): validate email #454

Merged
merged 2 commits into from
Mar 26, 2024
Merged

fix(newsletter): validate email #454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
245db8b
fix(newsletter): validate email
caugner Mar 26, 2024
5458d5a
chore(newsletter): remove unnecessary Debug derivation
caugner Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/api/newsletter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use actix_web::{
use basket::{Basket, SubscribeOpts, YesNo};
use diesel::PgConnection;
use serde::{Deserialize, Serialize};
use validator::Validate;

use crate::{
api::error::ApiError,
Expand All @@ -31,8 +32,9 @@ struct Subscribed {
pub subscribed: bool,
}

#[derive(Deserialize, Serialize)]
#[derive(Deserialize, Serialize, Validate)]
pub struct SubscriptionRequest {
#[validate(email(message = "must be an email address"))]
pub email: String,
}

Expand All @@ -53,6 +55,7 @@ pub async fn subscribe_anonymous_handler(
basket: Data<Option<Basket>>,
subscription_req: web::Json<SubscriptionRequest>,
) -> Result<HttpResponse, ApiError> {
subscription_req.validate()?;
if let Some(basket) = &**basket {
basket
.subscribe(
Expand Down
Loading