Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-help): artificial error triggers properly in the chat phase #452

Merged
merged 9 commits into from
Mar 21, 2024
Merged

fix(ai-help): artificial error triggers properly in the chat phase #452

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c5a3078
added triggers for errors in ai help
argl Mar 11, 2024
6875c2a
typo
argl Mar 12, 2024
1448f36
typo
argl Mar 12, 2024
0fcdba3
Update src/api/ai_help.rs
argl Mar 18, 2024
0efeab7
Update src/ai/help.rs
argl Mar 18, 2024
ba3c9bb
Merge branch 'main' into MP-708-add-qa-questions-to-trigger-error
argl Mar 18, 2024
3a4bac8
Merge branch 'main' into MP-708-add-qa-questions-to-trigger-error
argl Mar 19, 2024
e280cc2
Merge branch 'main' into MP-708-add-qa-questions-to-trigger-error
argl Mar 21, 2024
dc87004
fix(ai-help): artificial error triggers properly work in the chat phase
argl Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/api/ai_help.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,6 @@ pub async fn ai_help(

match prepare_res? {
Some(ai_help_req) => {
qa_check_for_error_trigger(&ai_help_req.req.messages)?;

let sources = ai_help_req.refs;
let created_at = match record_sources(
&diesel_pool,
Expand Down Expand Up @@ -447,10 +445,15 @@ pub async fn ai_help(
user.id,
help_ids,
)?;
let qa_error_triggered =
qa_check_for_error_trigger(&ai_help_req.req.messages).is_err();
let stream = client.chat().create_stream(ai_help_req.req).await.unwrap();
let refs = stream::once(async move {
let sse_data =
sse::Data::new_json(ai_help_meta).map_err(OpenAIError::JSONDeserialize);
let sse_data = if qa_error_triggered {
Err(OpenAIError::InvalidArgument("Artificial Error".to_owned()))
} else {
sse::Data::new_json(ai_help_meta).map_err(OpenAIError::JSONDeserialize)
};
match sse_data {
Ok(sse_data) => Ok(sse::Event::Data(sse_data)),
Err(err) => {
Expand Down
Loading