boot: bootutil: loader: Fix issue with stuck revert #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nordicjm
commented
Feb 10, 2025
nordicjm
commented
Fixes an issue (only for swap using move, unsure if it affects other modes) whereby a device can get into a state that there is a valid primary image, no secondary image but the primary image flag is still set to revert, which then makes loading a firmware update from the application impossible due to it assuming that a revert will happen upon device reboot Signed-off-by: Jamie McCrae <[email protected]>
Adds a note on this fix Signed-off-by: Jamie McCrae <[email protected]>
de-nordic
approved these changes
Feb 11, 2025
de-nordic
reviewed
Feb 11, 2025
| boot_swap_type_multi(BOOT_CURR_IMG(state)) == BOOT_SWAP_TYPE_REVERT) { | ||
| const struct flash_area *fap_pri; | ||
|
|
||
| rc = flash_area_open(flash_area_id_from_multi_image_slot(BOOT_CURR_IMG(state), |
There was a problem hiding this comment.
I guess that flash_area_id_from_multi_image_slot returning -1 never happens here.
There was a problem hiding this comment.
would be a very interesting flash setup heh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.