Fix task slash commands being run. (#1889)

* Fix task slash commands being run. * Style fix.
mattermost · Mar 13, 2024 · 0ed94b0 · 0ed94b0
1 parent 363c6dc
commit 0ed94b0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/server/api/playbook_runs.go b/server/api/playbook_runs.go
@@ -3,6 +3,7 @@ package api
 import (
 	"encoding/json"
 	"fmt"
+	"io"
 	"net/http"
 	"net/url"
 	"sort"
@@ -1311,6 +1312,12 @@ func (h *PlaybookRunHandler) itemRun(c *Context, w http.ResponseWriter, r *http.
 	}
 	userID := r.Header.Get("Mattermost-User-ID")
 
+	// Check the body is empty
+	if _, err := r.Body.Read(make([]byte, 1)); err != io.EOF {
+		h.HandleErrorWithCode(w, c.logger, http.StatusBadRequest, "request body must be empty", nil)
+		return
+	}
+
 	triggerID, err := h.playbookRunService.RunChecklistItemSlashCommand(playbookRunID, userID, checklistNum, itemNum)
 	if err != nil {
 		h.HandleError(w, c.logger, err)

diff --git a/webapp/src/client.ts b/webapp/src/client.ts
@@ -699,7 +699,7 @@ export const doGet = async <TData = any>(url: string) => {
     return data;
 };
 
-export const doPost = async <TData = any>(url: string, body = {}) => {
+export const doPost = async <TData = any>(url: string, body: any = undefined) => {
     const {data} = await doFetchWithResponse<TData>(url, {
         method: 'POST',
         body,
@@ -708,7 +708,7 @@ export const doPost = async <TData = any>(url: string, body = {}) => {
     return data;
 };
 
-export const doPut = async <TData = any>(url: string, body = {}) => {
+export const doPut = async <TData = any>(url: string, body: any = undefined) => {
     const {data} = await doFetchWithResponse<TData>(url, {
         method: 'PUT',
         body,