Store Credential id with passkey #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The odds that the parsing are correct is basically zero, but right now I can't even build this locally so hopefully CI has better luck?
Parsing it from the auth data would only work on creation, not on get
can't figure out how to update pnpm lockfile
Also allows checking if the passkey exists so you can avoid adding the same passkey to multiple accounts on the same domain
cpb8010
force-pushed
the
passkey-by-id
branch
from
c125c79 to
43dd3e2
Compare
Annoying to do between two repos with the lockfile
For cross-origin support it would be possible to try the same key on another domain. You also might want to check if you have an account already without knowing your address and just your passkey
cpb8010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support multiple passkeys per domain by looking up the credential id from the authenticator data. This is more efficient than just making a list and provides more information to passkey and account management.
Additional context
We also want to update the SDK to support this new init format and to use this credential id in this module instead of storing it as the unique id within the factory.