-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3954: Extensible Events - Text Emotes #3954
Open
turt2live
wants to merge
2
commits into
main
Choose a base branch
from
travis/msc/extev/emotes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Extensible events: Emotes
- Loading branch information
commit 178e320d6f1cbec2a6c6d6dfa5dfee12147838c2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# MSC3954: Extensible Events - Text Emotes | ||
|
||
[MSC1767](https://github.com/matrix-org/matrix-doc/pull/1767) describes Extensible Events in detail, | ||
though deliberately does not include schemas for some messaging types. This MSC covers a replacement | ||
for the `m.emote` `msgtype` specifically. | ||
|
||
*Rationale*: Splitting the MSCs down into individual parts makes it easier to implement and review in | ||
stages without blocking other pieces of the overall idea. For example, an issue with the way emotes | ||
are represented should not block the overall schema from going through. | ||
|
||
## Proposal | ||
|
||
MSC1767 allows for regular, non-emotive, text to be sent with an `m.message` event type and `m.markup` | ||
content block. This MSC simply introduces a new `m.emote` event type taking a **required** `m.markup` | ||
content block, enabling emotes in rooms supporting extensible events. | ||
|
||
An example: | ||
|
||
```json5 | ||
{ | ||
// irrelevant fields not shown | ||
"type": "m.emote", | ||
"content": { | ||
"m.markup": [{"body": "says hi"}] | ||
} | ||
} | ||
``` | ||
|
||
## Potential issues | ||
|
||
No significant issues known. | ||
|
||
## Alternatives | ||
|
||
It may be more desirable to create an emote mixin, however that raises questions like "what does it mean | ||
to emote a poll". For simplicity, or at least until a use case arises, this MSC aims to directly replace | ||
the `m.emote` `msgtype` instead - a future MSC can expand support for the feature. | ||
|
||
## Security considerations | ||
|
||
No specific considerations are required for this proposal. | ||
|
||
## Unstable prefix | ||
|
||
While this MSC is not considered stable, implementations should use `org.matrix.msc1767.*` as a prefix in | ||
place of `m.*` throughout this proposal. Note that this uses the namespace of the parent MSC rather than | ||
the namespace of this MSC - this is deliberate. | ||
|
||
Note that extensible events should only be used in an appropriate room version as well. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheArcaneBrony says: