-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matrix-bot-sdk and other packages #415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken due to turt2live/matrix-bot-sdk#247 |
tadzik
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – though I wonder where the ReadStream deprecation is going to bite us. Certainly makes sense to not do it here though.
Half-Shot
force-pushed
the
hs/update-bot-sdk
branch
from
July 25, 2022 17:01
5ef93ec
to
fa46e1f
Compare
Half-Shot
force-pushed
the
hs/update-bot-sdk
branch
from
July 25, 2022 17:02
fa46e1f
to
492ede4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the bot-sdk to 0.6.0, and other packages to their latest versions (where possible). We've also had to deprecate uploading files directly from a ReadStream as converting RS into Buffer isn't possible on Node 14 directly, and writing the code to do so felt out of scope for this library.