Add option for a time to live for membership queue items #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
requested review from
a team and
jaller94
and removed request for
a team
jaller94
approved these changes
Nov 13, 2020
…ervice-bridge into hs/ttl-membership
I think this is covered by the default opts values? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for matrix-org/matrix-appservice-irc#1184
Depends on #276
This change allows us to specify a maximum ttl of a request before we just consider it stale and drop it. I've also renamed
joinDelayMstoactionDelayMsbecause it doesn't just affect joins.