Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly reference our TypeScript types #223

Closed
wants to merge 1 commit into from
Closed

Explicitly reference our TypeScript types #223

wants to merge 1 commit into from

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Sep 4, 2020

Apparently that's how you tell other projects that you included the types in your NPM bundle.

https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package

@jaller94 jaller94 requested a review from a team September 4, 2020 14:27
Half-Shot
Half-Shot approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, forgot about this. Nice 👍

@jaller94
Copy link
Contributor Author

jaller94 commented Sep 4, 2020

Now part of #224

@jaller94 jaller94 closed this Sep 4, 2020
@jaller94 jaller94 deleted the j94/declare-types branch September 4, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaller94 @Half-Shot