Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to TypeScript4 #219

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Upgrade to TypeScript4 #219

merged 3 commits into from
Sep 14, 2020

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Sep 4, 2020

We don't seem to be affected by any of the breaking changes.

https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#breaking-changes

I will test this over the course of today.

@jaller94 jaller94 requested review from a team and removed request for a team September 4, 2020 10:36
@jaller94 jaller94 self-assigned this Sep 4, 2020
@jaller94
Copy link
Contributor Author

jaller94 commented Sep 8, 2020

ESLint seems to have an (invalid?) issue with the transformed code:

/workdir/src/components/room-link-validator.ts
176:13  error  'RoomLinkValidatorStatus' is already declared in the upper scope  no-shadow

@Half-Shot Half-Shot merged commit 4102cd7 into develop Sep 14, 2020
@jaller94 jaller94 removed their assignment Sep 28, 2020
@jaller94 jaller94 deleted the j94/typescript4 branch November 13, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaller94 @Half-Shot