Skip to content

Commit

Permalink
Add comment to PentaDb referring to #151
Browse files Browse the repository at this point in the history
  • Loading branch information
reivilibre committed Jan 13, 2023
1 parent 1b5c1c4 commit d46f0f2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/backends/penta/db/PentaDb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ export class PentaDb {
this.isConnected = false;
}

/**
* Gets a person by ID. Can returns multiple results because a person with the same ID may be defined multiple times
* acting in different capacities, e.g. speaker of one talk, coordinator of another.
* TODO Normalise this and ensure that a person is only defined once, with the roles split out from the definition of a person.
* see: https://github.com/matrix-org/conference-bot/issues/151
*/
public async findPeopleWithId(personId: string): Promise<IPerson[]> {
const numericPersonId = Number(personId);
if (Number.isSafeInteger(numericPersonId)) {
Expand Down

0 comments on commit d46f0f2

Please sign in to comment.