Support applying middleware to both subscription subscribe and resolve functions #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e applied to both subscribe and resolve subscription resolver functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem defn
When using GraphQL shield to apply rules across the schema, subscription rules are not executed for subscription subscribe operations.
Issue
The
applyMiddlewareToFieldfunction does not take into account that subscription resolvers can have bothsubscribeandresolvefunctions defined.When
applyMiddlewareToFieldruns, ifresolveis defined,subscribeis ignored.This means that GraphQL shield rules (and other middlewares) are not applied to subscription subscribe operations.
Proposed fix
@leiyangyou posted a patch over here:
#561
This patch worked for me, allowing GraphQL shield middleware rules to be executed during the subscribe operation of subscriptions.
All the tests pass with this variant of
applyMiddlewareToField, however it is a pretty solid change to the function's structure.I was not quickly able to work out how to add a test validating the proposed fix.