Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(drawer): Update menu icon to be anchor element #2372

Merged
merged 2 commits into from
Mar 9, 2018
Merged

fix(drawer): Update menu icon to be anchor element #2372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e107a21
fix(drawer): Update menu icon to be anchor element
williamernest Mar 9, 2018
9b60982
fix(drawer): Update for comments
williamernest Mar 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion demos/drawer/persistent-drawer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
<header class="mdc-toolbar mdc-elevation--z4">
<div class="mdc-toolbar__row">
<section class="mdc-toolbar__section mdc-toolbar__section--align-start">
<button class="demo-menu material-icons mdc-toolbar__menu-icon">menu</button>
<a href="#" class="demo-menu material-icons mdc-toolbar__menu-icon">menu</a>
<span class="mdc-toolbar__title catalog-title">Persistent Drawer</span>
</section>
</div>
Expand Down Expand Up @@ -141,6 +141,7 @@ <h1 class="mdc-typography--display1">Persistent Drawer</h1>
<button type="button" class="mdc-button mdc-button--stroked mdc-button--dense demo-toolbar-example-heading__rtl-toggle-button">Toggle RTL</button>
</main>

<script src="/assets/common.js" async></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think we'd been standardizing on putting common.js after mcw.js (I realize now I missed this in top-app-bar).

<script src="/assets/material-components-web.js" async></script>
<script>
demoReady(function() {
Expand Down
3 changes: 2 additions & 1 deletion demos/drawer/temporary-drawer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<div class="mdc-toolbar mdc-toolbar--fixed">
<div class="mdc-toolbar__row">
<section class="mdc-toolbar__section mdc-toolbar__section--align-start">
<button class="demo-menu material-icons mdc-toolbar__menu-icon">menu</button>
<a href="#" class="demo-menu material-icons mdc-toolbar__menu-icon">menu</a>
<span class="mdc-toolbar__title catalog-title">Temporary Drawer</span>
</section>
</div>
Expand Down Expand Up @@ -130,6 +130,7 @@ <h1 class="mdc-typography--display1">Temporary Drawer</h1>
</div>
</main>

<script src="/assets/common.js" async></script>
<script src="/assets/material-components-web.js" async></script>
<script>
demoReady(function() {
Expand Down