Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(select): Remove list CSS, and use mdc-list styles directly #2065

Merged
merged 2 commits into from
Jan 24, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions packages/mdc-select/mdc-select.scss
Original file line number Diff line number Diff line change
Expand Up @@ -219,64 +219,6 @@ $mdc-select-menu-transition: transform 180ms $mdc-animation-standard-curve-timin

// postcss-bem-linter: end

.mdc-select__menu {
.mdc-list-item {
@include mdc-typography(subheading2);
@include mdc-theme-prop(color, text-secondary-on-light);

&[aria-selected="true"] {
@include mdc-theme-prop(color, text-primary-on-light);
}

@include mdc-theme-dark(".mdc-select") {
@include mdc-theme-prop(color, text-secondary-on-dark);

&[aria-selected="true"] {
@include mdc-theme-prop(color, text-primary-on-dark);
}
}

// Styles to override mdc-ripple-radius from mdc-list, which causes display glitches in Chrome
// (See https://github.com/material-components/material-components-web/pull/1737#issuecomment-351105800)
@include mdc-ripple-radius(50%);

&::before,
&::after {
border-radius: 0;
}
}

.mdc-list-group,
.mdc-list-group > .mdc-list-item:first-child {
margin-top: 12px;
}

.mdc-list-group {
@include mdc-theme-prop(color, text-hint-on-light);

font-weight: normal;

.mdc-list-item {
@include mdc-theme-prop(color, text-primary-on-light);
}
}

@include mdc-theme-dark(".mdc-select") {
.mdc-list-group {
@include mdc-theme-prop(color, text-hint-on-dark);

.mdc-list-item {
@include mdc-theme-prop(color, text-primary-on-dark);
}
}
}
}

// height for option elements cannot be controlled
// with CSS. Use the font-size rule instead.

// postcss-bem-linter: end

.mdc-select-scroll-lock {
overflow: hidden;
}