ica_reclassify logger fix #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: update README.md * docs: update .all-contributorsrc --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Signed-off-by: fazledyn-or <[email protected]>
* added version numbers * Add lib info to html report
* docs: update README.md * docs: update .all-contributorsrc --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Dan Handwerker <[email protected]> Co-authored-by: handwerkerd <[email protected]>
* Update index.rst Changed newsletter from TinyLetter to new google groups link. * Update README.md Changed newsletter link from TinyLetter to Google Groups * Update README.md Changed the content from tinyletter to google groups * Update support.rst updated newsletter link to google groups * Update README.md Co-authored-by: Eneko Uruñuela <[email protected]> * Update docs/index.rst Co-authored-by: Eneko Uruñuela <[email protected]> * Update README.md * Update support.rst * Update README.md --------- Co-authored-by: Eneko Uruñuela <[email protected]>
…E-ICA#1018) * docs: update README.md * docs: update .all-contributorsrc --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* Run new version of black. * Run isort.
…E-ICA#1024) * Create dependabot.yml * Drop release drafter in favor of release config.
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v2...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Base versions on last CircleCI 3.8 env build. * Base max versions on 3.12 test. * Set minimum versions too. * Update pyproject.toml Co-authored-by: Dan Handwerker <[email protected]> --------- Co-authored-by: Dan Handwerker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinezeguiluz Thank you so much for working on this and I apologize for my delay reviewing.
I noticed one subtle issue. In your PR, you are calling
LGR.warningbut that happens beforeutils.setup_loggersis called to set up the logger to actually log the warnings. In this PR, I'm movingutils.setup_loggershigher up in the function so that the warnings you added will now be appropriated logged.Once you merge this PR into yours (assuming you don't see any new issues) I'm fine approving.
(Also, I've been running tedana with python 3.12 and there are a couple more style complaints in
pca.pyandselection_nodes.pythat weren't flagged with older versions of python. To make the linter happy, I just corrected them here.