Fixed #487: added MLCP_HOME/bin to PATH

[grtjn]

#487

Anyone around that can run a quick test on Windows? Runs fine on Mac..

[patrickmcelwee]

Geert,

I suggest setting HADOOP_HOME too. That was an issue I ran into while working through #542 . I was not able to run a completely successful test on Windows, since I ran into another problem with mlcp 1.3-3 on Windows 10 (again, see #542 ) - but I think that problem was unrelated to this.

Here is how my code looked:

    env_variables = {"PATH" => "#{ENV['PATH']};#{mlcp_home}\bin", 
                                "HADOOP_HOME" => mlcp_home}
    system(env_variables, runme)

[grtjn]

I've added HADOOP_HOME too. Could you run a quick test with this to see if this works on Windows? (i.e. doesn't miserably fail when executing ml.bat local mlcp)

[patrickmcelwee]

Yep, an import of an XML doc worked for me. Though, it also worked against the current Roxy master. Not sure what that means. Possibly it is working just because I am using the most recent version of mlcp (8.0-4)

[grtjn]

If the change didn't help, then it didn't harm either. I think we can safely merge this..

[patrickmcelwee]

agreed