Convert virtualbase wrapper functions to friend functions #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mappu
force-pushed
the
miqt-friend-virtuals
branch
from
7d52ed2 to
30cd66e
Compare
mappu
force-pushed
the
miqt-friend-virtuals
branch
from
30cd66e to
aa6a401
Compare
arnetheduck
reviewed
Feb 12, 2025
| @@ -534,7 +496,9 @@ bool QsciAbstractAPIs_override_virtual_event(void* self, intptr_t slot) { | |||
| } | |||
|
|
|||
| bool QsciAbstractAPIs_virtualbase_event(void* self, QEvent* event) { | |||
| return ( (MiqtVirtualQsciAbstractAPIs*)(self) )->virtualbase_event(event); | |||
|
|
|||
| return ( (MiqtVirtualQsciAbstractAPIs*)(self) )->MiqtVirtualQsciAbstractAPIs::event(event); | |||
There was a problem hiding this comment.
oops, instead of calling the base class function, this actually calls the override version which goes on to call the language override in a nice infinite recursion ;)
This needs to be ( (MiqtVirtualQsciAbstractAPIs*)(self) )->QsciAbstractAPIs::event(event) + argument conversion
There was a problem hiding this comment.
The c.ClassName reference was right, but it got caught up in the fixupProtectedReferences logic. Probably it will need to be teased apart so that it still builds on Android.
This was referenced Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: #147
Updates: #166
Miqt supported calling the base/super method of any virtual override function. This worked by (A) creating a
virtualbase_...method wrapper in the subclass, and (B) also adding a C ABI function to call it.Combine these into a single C ABI function, following the
friendpattern of the new protected-method support. This reduces the number of functions generated in the translation unit.