Skip to content

Commit

Permalink
Fixes scaling issue identified in apache#7455
Browse files Browse the repository at this point in the history
  • Loading branch information
Jampani authored and madjam committed Aug 16, 2017
1 parent 7d6385a commit 521cf8b
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/kvstore/kvstore_dist.h
Original file line number Diff line number Diff line change
Expand Up @@ -232,17 +232,15 @@ class KVStoreDist : public KVStoreLocal {
}

// push to servers
send_buf.WaitToRead();
size_t size = send_buf.shape().Size();
auto push_to_servers =
[this, key, &send_buf](RunContext rctx, Engine::CallbackOnComplete cb) {
size_t size = send_buf.shape().Size();
#if MKL_EXPERIMENTAL == 1
mkl_set_tblob_eager_mode(send_buf.data());
mkl_set_tblob_eager_mode(send_buf.data());
#endif
real_t* data = static_cast<real_t*>(send_buf.data().dptr_);
auto push_to_servers =
[this, key, data, size](RunContext rctx, Engine::CallbackOnComplete cb) {
real_t* data = static_cast<real_t*>(send_buf.data().dptr_);
// convert to ps keys
PSKV& pskv = EncodeKey(key, size);

// do push. false means no delete
ps::SArray<real_t> vals(data, size, false);
CHECK_NOTNULL(ps_worker_)->ZPush(
Expand Down

1 comment on commit 521cf8b

@mli
Copy link

@mli mli commented on 521cf8b Aug 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update recv_buf as well. opened another PR apache#7489

Please sign in to comment.