Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sync #134

Merged
merged 8 commits into from
May 31, 2024
Merged

Feat/sync #134

merged 8 commits into from
May 31, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented May 29, 2024

Pull Request type

  • Refactoring (no functional changes, no API changes)
  • Perf

What is the current behavior?

What is the new behavior?

  • unnecessary removal of encode/decode to store the substrate block
  • calculating transaction hashes only once in convert_block
  • moving records of db mapping entries directly into l2_sync

Does this introduce a breaking change?

Other information

@jbcaron jbcaron self-assigned this May 29, 2024
@jbcaron jbcaron marked this pull request as ready for review May 29, 2024 09:32
@jbcaron jbcaron requested review from antiyro and cchudant May 29, 2024 09:32
@antiyro antiyro merged commit a914cd4 into madara-alliance:main May 31, 2024
7 checks passed
@jbcaron jbcaron deleted the feat/sync branch June 14, 2024 06:49
notlesh pushed a commit that referenced this pull request Jan 14, 2025
* update: JobItemUpdates

* update: changelog

* update: e2e fixed

* update: tests comments removed

* update: cleaning print statement

* update: version, updated_at will always automatically be updated

* update: version based job fetch test case

* fix: build

* update: simplified impl for update_job

* fix: lint

* update: false call check handled

* test update: panic if job is not found

* update: cleaned test case for db update_job

* update: shifted to_document to mongodb

* update: builder pattern for jobitemupdates

* update: default->new

* update: lint fix

* update: fixed fatal error

* update: match statement corrected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants