-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/limit repeated queries #93
Conversation
…of querying a given coldkey/ip only once per step
…oldkey_prob and unique_ip_prob constraints
Is this PR planned to be in the next release? Is it still WIP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but requires Typing in tests
only remaining issue is determinism in the unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…es/limit-repeated-queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but still needs typing in function definitions. Non blocking, but should be done
WIP throttle for disincentivizing large cabals by querying their hotkeys less often. Taken together with #92 this will query them less often and cause them to achieve lower scores.
This is an important step to increase the throughput of the network, while reducing repeated responses.