Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/limit repeated queries #93

Merged
merged 20 commits into from
Feb 13, 2024
Merged

Conversation

steffencruz
Copy link
Collaborator

WIP throttle for disincentivizing large cabals by querying their hotkeys less often. Taken together with #92 this will query them less often and cause them to achieve lower scores.

This is an important step to increase the throughput of the network, while reducing repeated responses.

@steffencruz steffencruz marked this pull request as ready for review February 7, 2024 16:14
@p-ferreira p-ferreira changed the base branch from main to staging February 8, 2024 17:39
@p-ferreira
Copy link
Contributor

p-ferreira commented Feb 8, 2024

Is this PR planned to be in the next release? Is it still WIP?

Copy link
Contributor

@mccrindlebrian mccrindlebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but requires Typing in tests

@steffencruz
Copy link
Collaborator Author

only remaining issue is determinism in the unit tests

Copy link
Contributor

@p-ferreira p-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffencruz
Copy link
Collaborator Author

Copy link
Contributor

@mccrindlebrian mccrindlebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but still needs typing in function definitions. Non blocking, but should be done

@steffencruz steffencruz merged commit e4d7c50 into staging Feb 13, 2024
3 checks passed
@mccrindlebrian mccrindlebrian deleted the features/limit-repeated-queries branch April 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants