HF and agent miners #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
p-ferreira
commented
Feb 6, 2024
•
p-ferreira
commented
- reorganizes base miners into prompting package to facilitate instrumentalization
- transforms zephyr miner into generic hf miner with support of 4 bit and 8 bit quantization
- update documentation for hf miner
- overall improvements on repo to enable miner offline integration
- modifies wiki agent miner to be a generic agent miner
- Adds two new base agents: SingleActionAgent and ReactAgent
- Adds support for hf in agent miner
- Adds tool miner
- updates requirements
p-ferreira
requested review from
steffencruz,
mccrindlebrian,
bkb2135 and
schampoux
mccrindlebrian
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
LGTM. I have done lots of testing off of this branch and have never run into issues.
Some comments:
-
Since we are removing agents, it does make sense to remove this from the code base all together since there is a lot of code related to agents. It would reduce the size of the PR quite a bit.
-
Lots of files have changed because it's blacked. So it might be nice to black whatever branch we are trying to merge this into
steffencruz
reviewed
Mar 1, 2024
steffencruz
reviewed
Mar 1, 2024
steffencruz
reviewed
Mar 1, 2024
The only gitignore of the repo has .DS_Store in it |
Co-authored-by: Steffen Cruz <[email protected]>
Co-authored-by: Steffen Cruz <[email protected]>
steffencruz
reviewed
Mar 1, 2024
Closed
Co-authored-by: Steffen Cruz <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.