Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock/tests #107

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Mock/tests #107

merged 6 commits into from
Feb 20, 2024

Conversation

steffencruz
Copy link
Collaborator

No description provided.

@steffencruz steffencruz changed the base branch from staging to pre-staging February 17, 2024 22:43
schampoux
schampoux approved these changes Feb 19, 2024
View reviewed changes
Copy link

@schampoux schampoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steffencruz
Copy link
Collaborator Author

steffencruz commented Feb 20, 2024 •
edited
Loading

@p-ferreira could you please troubleshoot the issue that is causing 1 test to fail?

E           bittensor.errors.KeyFileError: Keyfile at: /home/runner/.bittensor/wallets/default/hotkeys/default does not exist

The file should exist, unless the test runner environment is not allowing that path to be created. If so, you could manually create the file using os or try to change the wallet path. thanks.

@p-ferreira
Copy link
Contributor

@p-ferreira could you please troubleshoot the issue that is causing 1 test to fail?

E           bittensor.errors.KeyFileError: Keyfile at: /home/runner/.bittensor/wallets/default/hotkeys/default does not exist

The file should exist, unless the test runner environment is not allowing that path to be created. If so, you could manually create the file using os or try to change the wallet path. thanks.

One easier solution for the issue is to pass the bt.MockWallet() to MockDendrite. This seems to have fixed the tests

@p-ferreira p-ferreira mentioned this pull request Feb 20, 2024
Merged
@steffencruz steffencruz merged commit a5db577 into pre-staging Feb 20, 2024
3 checks passed
@steffencruz steffencruz mentioned this pull request Feb 21, 2024
Merged
@mccrindlebrian mccrindlebrian deleted the mock/tests branch April 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-ferreira p-ferreira p-ferreira approved these changes

@schampoux schampoux schampoux approved these changes

Assignees
No one assigned
Labels
v1.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steffencruz @p-ferreira @schampoux