Skip to content

Terminal conjugated bonds in distance geometry checks #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

chmnk
Copy link
Contributor

@chmnk chmnk commented Apr 14, 2025

A follow-up of #62, inspired by what we have in https://github.com/rdkit/rdkit/blob/master/Code/GraphMol/MolAlign/AlignMolecules.cpp#L27

Changes the distance geometry check for some terminal conjugated bonds:

  • gets the bonds from a SMARTS match to a conjugated bond template
  • since to my understanding, the conjugated bonds are usually between a single/double, it groups all those bonds by atom types
  • for each set of atom types (C--O, N--O), the lower/higher bound will be the minimum/maximum of the lower/higher bounds with this atom type.

@maabuu maabuu merged commit 96cb955 into maabuu:main Apr 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants