Add "fixJava8Classpath" option to support multirelease projects #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain environments that build multirelease jars, the Maven "classes" directory contains class files with newer Java versions, whereas the Java 8 versions are stored elsewhere. This prevents retrolambda from working, as java.lang.UnsupportedClassVersionError is thrown. Add a boolean "fixJava8Classpath" option that, once enabled, automatically fixes these classpath entries. It checks for the presence of a sibling directory named "classes-java8". If that's available, then the original classpath entry is replaced.
kohlschuetter
force-pushed
the
ck/fixJava8Classpath
branch
from
5f5128b to
c39e87e
Compare
|
Requires a test case to reproduce whatever was the issue. "classes-java8" sounds like something project specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain environments that build multirelease jars, the Maven "classes" directory contains class files with newer Java versions, whereas the Java 8 versions are stored elsewhere.
Add a boolean "fixJava8Classpath" option that, once enabled, automatically fixes these classpath entries. It checks for the presence of a sibling directory named "classes-java8". If that's available, then the original classpath entry is replaced.