Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TouchControls: Take FOV into account for camera movement #15936

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

grorp
Copy link
Member

@grorp grorp commented Mar 24, 2025

fixes #15935

This just applies #11007 to touchscreen as well. I don't know why this wasn't done there, probably because the author didn't want to bother with mobile (the bar was higher back then). This PR doesn't do anything additional like implementing a setting, but feel free to do so in another PR.

To do

This PR is a Ready for Review.

How to test

Test playing Luanti on mobile.

  • Sensitivity should be the same as before with FOV = 72 (the default)
  • Sensitivity should now be much more usable if zoomed in (try guns with scope, e.g. A.E.S. Block League)

@grorp grorp added Android Bugfix 🐛 PRs that fix a bug @ Client / Controls / Input UI/UX Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Mar 24, 2025
@Soupborsh
Copy link
Contributor

I tested this, it work perfectly fine. Aiming is much more convenient and works as expected.

Copy link
Contributor

@y5nw y5nw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@grorp grorp merged commit b0bc6ce into luanti-org:master Mar 28, 2025
17 checks passed
@grorp grorp deleted the touch-fov-camera branch March 28, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Bugfix 🐛 PRs that fix a bug @ Client / Controls / Input Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touchscreen zoom sensitivity scaling
3 participants