-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement secondary keybindings #15934
Draft
y5nw
wants to merge
24
commits into
luanti-org:master
Choose a base branch
from
y5nw:secondary-keybindings-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d83f156
to
596f89d
Compare
Co-authored-by: SmallJoker <[email protected]>
This reverts commit cf4f86a.
8bc3351
to
79d73dc
Compare
79d73dc
to
52b0f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@ Client / Controls / Input
Feature ✨
PRs that add or enhance a feature
Waiting (on dependency)
Waiting on another PR or external circumstances (not for rebases/changes requested)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked version of #15577, written in a way that reduces conflict with future work (e.g. for keybindings with modifiers). The first few commits are separated into #15933 for easier review.
This PR depends on (and is also rebsaed on top of) #15791.
Allows players to define secondary keybindings, e.g. left and right shift for the same action.
(See Refactor input handler #15933 for the first few commits.)
It introduces the syntax of
key1|key2
, withkey1
andkey2
being keysyms.On top of the first few commits, the event handler is changed to recheck whether an action should be "pressed" or not. (Note that the logic for pressing the key is not short-circuited to set the action - this is helpful for a later PR to implement modifier keys.)
No.
No.
E.g. SDL: Use scancodes for keybindings #14964 (comment)
To do
This PR is a Work in Progress.
How to test
Add e.g.
keymap_right = SYSTEM_SCANCODE_7|SYSTEM_SCANCODE_9
and observe that both the D and F keys move the player to the right.