-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hotbar_itemcount by hotbar_source #15905
base: master
Are you sure you want to change the base?
Conversation
I removed the hotbar element feature and will put it in another PR. (We will probably still want the feature, though, and I had to implement the functionality anyway to handle the So with this PR you can no longer change which parts of the hotbar the hud element uses, it always uses all inventories of the hotbar source. (Like it is the case in master, but only with a fixed inventory.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the concept of this PR, thus here's the first iteration of my review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I fixed most things, I hope.
The macos pipeline seems to be broken, for some reason, but this PR is ready for review again. |
hotbar_source
and thus dehardcodes the"main"
player inventory.Adds features to the hotbar HUD element, to specify which parts of theMoved to a followup PR.hotbar_source
it uses.get_wield_list()
already existed, and I added a note to not useset_hotbar_source()
together with outdated mods that rely on the list being"main"
.To do
Ready for Review.
How to test
/hudhotbars
threetwo times and notice that the hotbars behave like specified in lua_api.mdhud_hotbar_max_width
setting still works as expected./hudinventories
and see that it still behaves the same/unittests