Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New header image for the main menu #15826

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

siliconsniffer
Copy link
Contributor

@siliconsniffer siliconsniffer commented Feb 24, 2025

Add compact, short information about your PR for easier understanding:
Adds a new header image which is a pixelated version made by @Zughy - original artwork made by @SumianVoice.

How to test

Look at the new image.

Screenshot

image

@Zughy Zughy added @ Mainmenu Feature ✨ PRs that add or enhance a feature labels Feb 24, 2025
@Zughy
Copy link
Contributor

Zughy commented Feb 24, 2025

The logotype itself is good (I'm not saying it because it's mine, in the end I've only pixelated the original by Sumi), but I do agree with you when you say that it looks like "ahead" of its time. The whole main menu is dull, whereas the logotype is very bright and colourful. Also the contrast with the background is not great, but for that maybe a thicker outline might suffice

@Zughy Zughy added the Roadmap The change matches an item on the current roadmap label Feb 24, 2025
@siliconsniffer
Copy link
Contributor Author

siliconsniffer commented Feb 24, 2025

I really like it too, and while it might not fit perfectly now, I think it could be a great transition to a long-term main redesign (iirc you also had a proposal including this logo) as discussed in #6733 (comment).

@DragonWrangler1
Copy link
Contributor

The logo is nice, but... It really stands out, as in I really don't think it fits with the current design

@grorp
Copy link
Member

grorp commented Feb 28, 2025

Honestly I have to agree that this looks "off", the fresh and colorful look of the header image doesn't fit with the old-ish grey-gradient menu style in my eyes.

However it did look better in combination with the removal of the button gradients, see the screenshot in #6733 (comment)

I feel like if we do both of these modern/fresh looking things together, it could fit together and turn out nicely, what do others think?

@appgurueu
Copy link
Contributor

Dare I say: Maybe we should consider introducing some accent color into our default styles that isn't a shade of grey? Maybe some shade of green 1, or blue?

As it stands, our default styles are literally 50 shades of grey.

Footnotes

  1. which is already used a bit, see e.g. the text field or selected serverlist entry

@Zughy
Copy link
Contributor

Zughy commented Feb 28, 2025

I wouldn't touch anything else for now, leaving that to any potential art team

@DragonWrangler1
Copy link
Contributor

I'm no core dev, but wouldn't it be better to update whole menu pages once so everything matched a theme rather than having multiple different looks in one page ?

@siliconsniffer
Copy link
Contributor Author

Also the contrast with the background is not great, but for that maybe a thicker outline might suffice.

Or maybe make the logo a bit bigger? A thicker outline sounds reasonable.

I feel like if we do both of these modern/fresh looking things together, it could fit together and turn out nicely, what do others think?

That's the plan if no one objects. I'd adopt ROller's PR in a new one but I also want to address SmallJoker's concerns - I suggest discussing details about the buttons in the PR once its open. Currently I am struggling with Irrlicht though, could take me a bit.

Maybe we should consider introducing some accent color into our default styles that isn't a shade of grey? Maybe some shade of green 1, or blue?

Maybe from the same palette the image is using?

I wouldn't touch anything else for now, leaving that to any potential art team

Well, we're not doing a full redesign here - I think those changes are small enough to not need an art team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ✨ PRs that add or enhance a feature @ Mainmenu Possible close Roadmap The change matches an item on the current roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants