Allow specifying libc for Linux install #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonamo
force-pushed
the
glibc-on-non-glibc-machine
branch
from
ace1350 to
d2c83b0
Compare
joonamo
force-pushed
the
glibc-on-non-glibc-machine
branch
from
d2c83b0 to
94b50c3
Compare
lovell
reviewed
Apr 24, 2022
There was a problem hiding this comment.
Thank you very much for the PR, I've left one question inline. It might also be worth adding a unit test for overriding npm_config_libc to https://github.com/lovell/sharp/blob/main/test/unit/platform.js for consistency with the other npm_config_* env vars we support.
joonamo
changed the title
|
Kiitos! |
|
Good morning! Was this included in v0.30.5? I can't see it in the changelog 🤔 |
lovell
added a commit
that referenced
this pull request
May 24, 2022
|
Yes, sorry, I somehow missed adding it to the changelog. It's there now via commit 93b2905 - thanks again Joona for all your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sibling PR to PR in upstream dependency prebuild-install and should fix #3159.