DEV-46209 Fix missing logz headers for queries apis #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the way the logzio headers are being fetched in the clients, but didn't add it in all places that were adding the headers. This caused the elasticsearch datasources not to work because these headers are needed for these requests.
|
run-test |
ohadza
approved these changes
Aug 26, 2024
yasmin-tr
deleted the
DEV-46209-fix-missing-logz-headers-for-queries-apis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
The way the logzio headers are being fetched in the clients was changed,
but wasn't added in all places that were adding the headers.
This caused the elasticsearch datasources not to work because these headers are needed for these requests.
Why do we need this feature?
To have logzio datasources working, specifically logs datasources.