Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle callback error #64

Merged
merged 1 commit into from
Oct 29, 2021
Merged

feat: handle callback error #64

merged 1 commit into from
Oct 29, 2021

Conversation

wangsijie
Copy link
Contributor

Summary

throw error when redirect-back-url contains error, example url:
http://localhost:3000/callback?error=invalid_request&error_description=code_challenge%20must%20be%20a%20string%20with%20a%20minimum%20length%20of%2043%20characters

Linear Issue Reference

LOG-204

Testing

see unit tests

@wangsijie wangsijie force-pushed the wangsijie--redirect-error branch from 419d0d2 to d6a6277 Compare October 29, 2021 07:55
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

@wangsijie wangsijie force-pushed the wangsijie--redirect-error branch from 63dc7ef to f3b36cc Compare October 29, 2021 08:47
@wangsijie wangsijie force-pushed the wangsijie--redirect-error branch from 5d093d4 to 06561e2 Compare October 29, 2021 08:55
@wangsijie wangsijie merged commit c7d0b6a into master Oct 29, 2021
@wangsijie wangsijie deleted the wangsijie--redirect-error branch October 29, 2021 08:57
wangsijie added a commit that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants