-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster EntityKind deserialization #260
Faster EntityKind deserialization #260
Conversation
Hi @jackkoenig, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, nice to see someone using this! Looks mergeable, but one nitpick
We will need the signed CLA, too
src/main/scala/com/lightbend/tools/sculpt/model/ModelJsonProtocol.scala
Outdated
Show resolved
Hide resolved
if you rebase on current |
9284820
to
8235582
Compare
Thanks for the great tool, it's been very useful helping untangle a rats nest of circular dependencies 🙂
Yes of course, I am working on getting corporate to sign off. Might take a minute due to holidays.
Done, thanks for fixing CI! |
Split the string at the first colon rather than using regular expressions.
242e2ba
to
b9b5233
Compare
I added the new CLA checker and removed the old one from the branch protection rules, but the old one isn't going away here. I'm going to hope that it's fixed for future PRs and merge despite the old check failing. |
Thank you for the nice improvement! |
Split the string at the first colon rather than using regular expressions.
I'm using this on a large build unit. Loading the model was taking ~55 seconds--with this change it now takes 10 seconds.