Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster EntityKind deserialization #260

Merged

Conversation

jackkoenig
Copy link
Contributor

Split the string at the first colon rather than using regular expressions.

I'm using this on a large build unit. Loading the model was taking ~55 seconds--with this change it now takes 10 seconds.

@lightbend-cla-validator
Copy link
Collaborator

Hi @jackkoenig,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement:

http://www.lightbend.com/contribute/cla

Copy link
Contributor

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nice to see someone using this! Looks mergeable, but one nitpick

We will need the signed CLA, too

@SethTisue
Copy link
Contributor

if you rebase on current main (to get #249), that should fix CI

@jackkoenig jackkoenig force-pushed the faster-entitykind-deserialization branch from 9284820 to 8235582 Compare December 18, 2024 21:49
@jackkoenig
Copy link
Contributor Author

Hi, nice to see someone using this! Looks mergeable, but one nitpick

Thanks for the great tool, it's been very useful helping untangle a rats nest of circular dependencies 🙂

We will need the signed CLA, too

Yes of course, I am working on getting corporate to sign off. Might take a minute due to holidays.

if you rebase on current main (to get #249), that should fix CI

Done, thanks for fixing CI!

jackkoenig and others added 2 commits February 3, 2025 18:05
Split the string at the first colon rather than using regular
expressions.
@SethTisue SethTisue force-pushed the faster-entitykind-deserialization branch from 242e2ba to b9b5233 Compare February 4, 2025 02:05
@SethTisue SethTisue closed this Feb 4, 2025
@SethTisue SethTisue reopened this Feb 4, 2025
@SethTisue
Copy link
Contributor

SethTisue commented Feb 4, 2025

I added the new CLA checker and removed the old one from the branch protection rules, but the old one isn't going away here. I'm going to hope that it's fixed for future PRs and merge despite the old check failing.

@SethTisue SethTisue merged commit d3e53a2 into lightbend-labs:main Feb 4, 2025
18 of 19 checks passed
@SethTisue
Copy link
Contributor

Thank you for the nice improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants