feat: add multi-storage-client backend for file open #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
requested changes
Mar 4, 2025
lhotse/serialization.py
Outdated
|
|
||
| class MSCIOBackend(IOBackend): | ||
| """ | ||
| Uses multi-storage client to download data from object store |
There was a problem hiding this comment.
Can you add a link to MSC here? It'd be good to add 1-2 sentences about how MSC is different and what are it's unique features.
There was a problem hiding this comment.
Added a few lines to describe MSC and the documents' links. Let me know if that looks good
pzelasko
reviewed
Mar 17, 2025
pzelasko
reviewed
Mar 17, 2025
.github/workflows/unit_tests.yml
Outdated
| @@ -57,7 +57,7 @@ jobs: | |||
| # the torchaudio env var does nothing when torchaudio is installed, but doesn't require it's presence when it's not | |||
| pip install lilcom '.[tests]' | |||
| # Enable some optional tests | |||
| pip install h5py dill smart_open[http] kaldi_native_io webdataset==0.2.5 s3prl scipy nara_wpe pyloudnorm ${{ matrix.extra_deps }} | |||
| pip install h5py dill smart_open[http] kaldi_native_io webdataset==0.2.5 s3prl scipy nara_wpe pyloudnorm ${{ matrix.extra_deps }} multi-storage-client==0.16.0 | |||
There was a problem hiding this comment.
We'll have to move this requirement to extra_deps field in python version matrix, because Python 3.8 tests are failing (looks like MSC doesn't support that version anymore). Please add this to all python version tests starting from 3.9
pzelasko
previously approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Multi-Storage Client (MSC) backend to handle object storage access in Lhotse. The changes include:
Features
MSCIOBackendfor handling MSC protocol URLsLHOTSE_MSC_OVERRIDE_PROTOCOLSenv for supported protocols, e.g.s3://->msc://LHOTSE_MSC_PROFILEenv for profile/bucket name overrides, e.g.msc://my-bucket->msc://my-profileImplementation Details
Configuration
MSC behavior can be configured through environment variables:
LHOTSE_MSC_OVERRIDE_PROTOCOLS: Comma-separated list of protocols to override (e.g., "s3,gs")LHOTSE_MSC_PROFILE: Profile name to use for bucket overrideDependencies
multistorageclientpackage to be installed