Skip to content

Commit

Permalink
Modify cache-from cli arg to allow multiple values
Browse files Browse the repository at this point in the history
Documented usage of cache-from allows for users
to specify multiple images to search through by
passing the cache-from argument more than
once. Current implementation of cache-from as
a string does not enable this behavior.

See: moby/moby#26839 (comment)

Signed-off-by: Ryan Drew <[email protected]>
  • Loading branch information
learnitall committed Sep 7, 2021
1 parent b6c883d commit 55c2e1a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cli/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type BudResults struct {
Annotation []string
Authfile string
BuildArg []string
CacheFrom string
CacheFrom []string
CertDir string
Compress bool
Creds string
Expand Down Expand Up @@ -179,7 +179,7 @@ func GetBudFlags(flags *BudResults) pflag.FlagSet {
fs.StringArrayVar(&flags.Annotation, "annotation", []string{}, "Set metadata for an image (default [])")
fs.StringVar(&flags.Authfile, "authfile", "", "path of the authentication file.")
fs.StringArrayVar(&flags.BuildArg, "build-arg", []string{}, "`argument=value` to supply to the builder")
fs.StringVar(&flags.CacheFrom, "cache-from", "", "Images to utilise as potential cache sources. The build process does not currently support caching so this is a NOOP.")
fs.StringArrayVar(&flags.CacheFrom, "cache-from", []string{}, "Images to utilise as potential cache sources.")
fs.StringVar(&flags.CertDir, "cert-dir", "", "use certificates at the specified path to access the registry")
fs.BoolVar(&flags.Compress, "compress", false, "This is legacy option, which has no effect on the image")
fs.StringVar(&flags.Creds, "creds", "", "use `[username[:password]]` for accessing the registry")
Expand Down

0 comments on commit 55c2e1a

Please sign in to comment.