Map removal fix #340
Closed
Map removal fix #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Atul-source
requested review from
sanfern,
charleskbliu0,
jniesz,
dthaler,
ajayR006,
dalalkaran and
binojrajan
as code owners
aka320
reviewed
Feb 26, 2024
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
|
@Atul-source Please validate this case.
|
|
@Atul-source Better to handle the deletion of Map files while loading the eBPF program, instead of handling during stopping of eBPF program, so that we can guarantee that there are no duplicate Maps. |
sanfern
requested changes
Mar 8, 2024
kf/bpf.go
Outdated
| b.Program.Name, b.Program.ProgType, ifaceName, mapFilename, err) | ||
| } | ||
| if fileExists(mapFilename) { |
There was a problem hiding this comment.
If a BPF map is shared by multiple programs, and one program unpins the map while another program is still accessing it, it can lead to unpredictable behavior. To avoid this, you can check if the reference count of the map is less than 1 using v.GetRefCount(), and then proceed to delete the file.
There was a problem hiding this comment.
Is v.GetRefCount() a library function ?
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Unpinning the eBPF maps don't remove the files ( internally os.Remove not worked). In this PR I have added a condition when Unpinning doesn't remove the map file the we should Remove it.