Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): fix sysadvisor state reclaim pod's TopologyAwareAssignments i… #786

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

luomingmeng
Copy link
Collaborator

…s not equal to qrm state

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/fix-sysadvisor-reclaim-state branch from ddf7968 to 639a0ff Compare February 18, 2025 06:49
@luomingmeng luomingmeng force-pushed the dev/fix-sysadvisor-reclaim-state branch from 639a0ff to 3ad8c30 Compare February 18, 2025 07:45
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.53%. Comparing base (cdf8732) to head (e1f2148).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   60.61%   60.53%   -0.09%     
==========================================
  Files         604      604              
  Lines       63492    63496       +4     
==========================================
- Hits        38485    38436      -49     
- Misses      21154    21199      +45     
- Partials     3853     3861       +8     
Flag Coverage Δ
unittest 60.53% <87.50%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gary-lgy gary-lgy merged commit 8168777 into kubewharf:main Feb 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants