Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add OTel Tracing Headers and Baggage with CueX Requests #115

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

briankane
Copy link
Contributor

@briankane briankane commented Apr 2, 2025

Description of your changes

Adds tracing and baggage (app context) support using OTel for outbound CueX requests.
The externalserver package has been updated to reconstruct the context from the received headers.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

PR includes unit tests for both the outbound and inbound functionality.
Manual testing has been conducted to ship application workflow context & trace IDs from a Kubevela Application to a CueX server.

Special notes for your reviewer

N/A

@briankane briankane force-pushed the feature/cuex-tracing branch from 4cebeb5 to fd8a668 Compare April 3, 2025 00:06
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.71%. Comparing base (5199730) to head (1844bda).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cue/cuex/runtime/tracer.go 92.52% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   86.46%   86.71%   +0.24%     
==========================================
  Files          81       82       +1     
  Lines        3959     4071     +112     
==========================================
+ Hits         3423     3530     +107     
- Misses        402      408       +6     
+ Partials      134      133       -1     
Flag Coverage Δ
unit-test 86.71% <92.85%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@briankane briankane force-pushed the feature/cuex-tracing branch from fd8a668 to 7122881 Compare April 3, 2025 01:46
@briankane briankane force-pushed the feature/cuex-tracing branch from 7122881 to 03df3ab Compare April 7, 2025 23:00
@briankane briankane requested a review from anoop2811 as a code owner April 7, 2025 23:01
@briankane briankane requested a review from FogDong April 7, 2025 23:04
@briankane briankane force-pushed the feature/cuex-tracing branch from 03df3ab to 95cead8 Compare April 7, 2025 23:09
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding it!

@FogDong FogDong merged commit 3b6fbd2 into kubevela:main Apr 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants