-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (go/v4) update gitignore template comments and fix some nit typo issues #3717
🐛 (go/v4) update gitignore template comments and fix some nit typo issues #3717
Conversation
|
Welcome @mateusoliveira43! |
Hi @mateusoliveira43. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -47,14 +47,16 @@ const gitignoreTemplate = ` | |||
*.dylib | |||
bin | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugins go/v2 and go/v3 are deprecated for too long and will be removed in the first quarter
Therefore, could you please revert the changes on those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I will try to this in the next days. I was in doubt about CLA option, once I figure it out, I update it and the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. See here the steps to sign the CLA, you just need to register yourself: #3717 (comment) (less then 2 minutes)
Also, more one nit. Since it will change something for the endusers the right emoji is 🐛 and not 🌱 . More info can be found in the Contributing guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the emoji as well
My question with CLA is if I am Individual Contributor or Corporate Contributor. Once I get that checked, I will update the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry the delay
Now that the yer change, make generate
produces a lot of changes. Need to have a separate PR for just the year change. Do you want me to create that PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🥇
Note that the plugins go/v2, go/v3 are deprecated for a long period so we cannot change things on them. Therefore, could you please revert the changes made on those?
Also, see that you need to sign the CLA for we are able to get this PR merged, can you please check it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is all fine.
Well done 🥇
Could you please just squash the commits for we get this one merged
/ok-to-test
I wait #3719 get merged before finishing this one, to rebase on top of it Is the requirement of squashing the commits in contribute guidelines? |
Could you please:
So that we can move forward here? |
Signed-off-by: Mateus Oliveira <[email protected]>
17f2fdd
to
203e866
Compare
@camilamacedo86 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Update gitignore template for golang/v4 plugin (v2 and v3 are deprecated and will be removed soon) to be up to date with https://github.com/github/gitignore/blob/main/Go.gitignore
Motivation
Use the default template of GitHub
Related issues
No related issues